TheNetworg / oauth2-azure

Azure AD provider for the OAuth 2.0 Client.
https://packagist.org/packages/thenetworg/oauth2-azure
MIT License
230 stars 108 forks source link

Proposal: add "appid" query parameter #151

Closed infabo closed 2 years ago

infabo commented 2 years ago

If the application has custom signing keys you can add a appid parameter to the openid-configuration-URL, so you receive the correct jwks_uri with the additional keys.

see https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-protocols-oidc

image

https://github.com/TheNetworg/oauth2-azure/blob/3f8d322e9cb5b8713cc3cc785bbeef0165b921bf/src/Provider/Azure.php#L69

It may be safe to add the appid-queryparam in all cases.

hajekj commented 2 years ago

This is pretty neat, didn't know about this feature!