Update composer.json

[ThibaultPelloquin]

Prevents install of firebase/php-jwt 6.8 which is not currently compatible with thenetworg/oauth2-azure

[10n]

I'm just curious, what is the incompatibility?

https://github.com/firebase/php-jwt/releases

[ThibaultPelloquin]

Hi!

It throws this error with firebase/php-jwt 6.8 :

Maybe it's easily fixable 🤔

I don't know ^^,

Thibault

Le mar. 1 août 2023 à 15:08, Ionut Cioflan @.***> a écrit :

I'm just curious, what is the incompatibility?

https://github.com/firebase/php-jwt/releases

— Reply to this email directly, view it on GitHub https://github.com/TheNetworg/oauth2-azure/pull/192#issuecomment-1660278182, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBDMACQQRU2NZLFOYBEVG3XTD5UVANCNFSM6AAAAAA27ONI7E . You are receiving this because you authored the thread.Message ID: @.***>

[10n]

This was solved in 2.2.0 (we removed the 3rd argument)

https://github.com/TheNetworg/oauth2-azure/releases/tag/v2.2.0

https://github.com/TheNetworg/oauth2-azure/pull/189

https://github.com/TheNetworg/oauth2-azure/compare/v2.1.1...v2.2.0

[ThibaultPelloquin]

I tried it and nope... 😕

I you want we can check together one day but I'm sure it's not fixed in previous versions

Le mar. 1 août 2023, 16:23, Ionut Cioflan @.***> a écrit :

This was solved in 2.2.0 (we removed the 3rd argument)

189 https://github.com/TheNetworg/oauth2-azure/pull/189

v2.1.1...v2.2.0 https://github.com/TheNetworg/oauth2-azure/compare/v2.1.1...v2.2.0

— Reply to this email directly, view it on GitHub https://github.com/TheNetworg/oauth2-azure/pull/192#issuecomment-1660434928, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBDMAAWV3R7JGMBI4G2FZ3XTEGM5ANCNFSM6AAAAAA27ONI7E . You are receiving this because you authored the thread.Message ID: @.***>

[10n]

We can do that.

But comparing your screenshot with with the 2.2.1 release, the 3rd argument does not exist anymore. https://github.com/TheNetworg/oauth2-azure/blob/v2.2.1/src/Token/AccessToken.php

[10n]

Is it possible that you were encountering this issue on 2.1.1 and and while you were creating the pull-request the tag 2.2.0 was created and you did not reconfirm the bug?

Can you please downgrade in you project to 2.2.0 and see if the issue is happening.

Before the 2.2.0 was published, I was using successfully thenetworg/oauth2-azure:dev-master with firebase/php-jwt:6.8.1.

[10n]

@hajekj can you please have a look.

[ThibaultPelloquin]

If you want we can take a look in live Thursday morning.

On discord or somewhere else.

Le mar. 1 août 2023, 17:16, Ionut Cioflan @.***> a écrit :

Is it possible that this issue happening on 2.1.1 https://github.com/TheNetworg/oauth2-azure/releases/tag/v2.1.1 and and while you were creating the pull-request the 2.2.0 https://github.com/TheNetworg/oauth2-azure/releases/tag/v2.2.0 was created and you did not reconfirm the bug?

Can you please downgrade in you project to 2.2.0 and see if the issue is happening.

Before the 2.2.0 was published, I was using successfully thenetworg/oauth2-azure:dev-master with firebase/php-jwt:6.8.1.

— Reply to this email directly, view it on GitHub https://github.com/TheNetworg/oauth2-azure/pull/192#issuecomment-1660536142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBDMACNTWPJYNIWIV2OVDTXTEMVZANCNFSM6AAAAAA27ONI7E . You are receiving this because you authored the thread.Message ID: @.***>

[10n]

ok, let's try

[maciejlebkowski]

what’s the status on this? is the restriction introduced here actually valid?

[10n]

A new PR was created to remove it https://github.com/TheNetworg/oauth2-azure/pull/193