TheNetworg / oauth2-azure

Azure AD provider for the OAuth 2.0 Client.
https://packagist.org/packages/thenetworg/oauth2-azure
MIT License
229 stars 108 forks source link

Improve error messages #212

Closed curry684 closed 1 month ago

curry684 commented 1 month ago

Had a terrible Monday morning case of my local development VM missing NTP synchronization, spent 10 minutes figuring out why I was getting vague The id_token is invalid! errors all the time.

Improved error messages following Symfony standards: full grammatically correct sentences ending with a period, describing the real problem in detail including the most likely problem and solution.

The change at #369 repairs the broken tests on newer PHP versions (accessing a missing array value is a hard error now without null coalesce).

hajekj commented 1 month ago

Awesome! Thanks for this!