search

TheNetworg / oauth2-azure

Azure AD provider for the OAuth 2.0 Client.
https://packagist.org/packages/thenetworg/oauth2-azure
MIT License
230 stars 109 forks source link

Future development #82

Open davidpede opened 5 years ago

davidpede commented 5 years ago

@hajekj Can we get some clarity on how to proceed with active development?

I've contributed to branch v2.0.0 and have been using it in projects for a while now as it supports v2 endpoints and openid config etc. Has been stable for our use cases but prob still needs work.

I saw your comment here https://github.com/TheNetworg/oauth2-azure/pull/74#issuecomment-457863775 saying your ditching branch v2.0.0 and there are a few open prs now such as https://github.com/TheNetworg/oauth2-azure/pull/79 and https://github.com/TheNetworg/oauth2-azure/pull/76 aimed at master branch which duplicate some work already in v2.0.0.

Can you advise what branch you plan to use for v2 of this library so we know which to target for future commits. Or do we need to merge the 2 branches / create new one for v2 etc?

Happy to help as I make lot of use of this lib but need guidance on your plan

hajekj commented 5 years ago

Hello, the initial idea still is to proceed forward with development of v2 branch. I have however paused my own involvement, because I wanted to see where Microsoft takes both Azure AD and their own libraries (especially speaking of v2 endpoint and MSAL).

Right now, it is quite safe to say that v2 endpoint is okay to go, so I would proceed with keeping v1 version of this library to support v1 endpoint, and then having v2 version to support v2 endpoint if that makes sense. Since v2 endpoint is OIDC certified, it should be much easier to get up and running with it.

I am quite sorry I wasn't able to review and merge those incoming pull requests yet, it is on my to-do list still - and I will do my best to get it done during this weekend.

Let's keep this thread open to discuss the future. I would like to invest some more time in order to finish the v2 library and get it into production.

davidpede commented 5 years ago

Ok great so if Branch v2.0.0 is the next version (oauth2-azure v2) then can I suggest:

Like I said we've been using v2 endpoints with v2.0.0 for 6 months or so with no issues so a beta release shouldn't be to much work. Happy to help with v2 and yes lets keep this thread open to discuss

hajekj commented 5 years ago

I have merged some of the PRs. I want to setup some better test environment, so that I can test all those changes.

eotin commented 4 years ago

Hi @davidpede @hajekj I've referenced the branch v2.0.0.x-dev from packagist and this version 2.0 is well functioning by updating the metadata to "https://login.microsoftonline.com/tenantID/v2.0/.well-known/openid-configuration".

As davidepede mentionned there is some duplicate code from PR as #76 . How to you want to proceed ? But it could be nice to have a v2.0.0 stable branch that we can use via packagist.

Thanks a lot