TheNewEconomy / EconomyCore

The core code powering TNE.
Other
19 stars 5 forks source link

#55 adding support for gradle #62

Closed sunydepalpur closed 1 year ago

sunydepalpur commented 1 year ago

https://github.com/TheNewEconomy/EconomyCore/issues/55

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/TheNewEconomy/EconomyCore/62/3da570a7/4b52421dc353e9a4058407befd419b677411ad25.svg)](https://app.codesee.io/r/reviews?pr=62&src=https%3A%2F%2Fgithub.com%2FTheNewEconomy%2FEconomyCore) #### Legend CodeSee Map legend
sunydepalpur commented 1 year ago
Screenshot 2023-09-04 at 6 23 55 PM
creatorfromhell commented 1 year ago

Cheers, I'll review this tomorrow.

creatorfromhell commented 1 year ago
Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result:

image

sunydepalpur commented 1 year ago
Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result:

image

You can use intellIJ for the build, I can share the, build approach

sunydepalpur commented 1 year ago
Screenshot 2023-09-04 at 6 23 55 PM

Downloading and running a gradle build locally produces this result: image

You can use intellIJ for the build, I can share the, build approach

Added the build configs in PR

creatorfromhell commented 1 year ago

Reviewing this in more detail, this PR is severely flawed. Firstly, non of the dependencies have any repositories ported over to the gradle files, secondly the java conventions plugin isn't really needed in this case, it should be the "java-library" one. In essence, this looks like someone just ran gradle init, pushed it into a branch and slapped a PR for it.

creatorfromhell commented 1 year ago

PR is severely flawed, closing.