TheNewEconomy / EconomyCore

The core code powering TNE.
Other
8 stars 5 forks source link

[BUG]: Money request cannot be clicked #95

Open Aurelien30000 opened 1 month ago

Aurelien30000 commented 1 month ago

TNE Version

0.1.2.9

Spigot Version

1.20.4

Your config.yml

https://paste.domicraft.fr/ekobalogew.yaml

Your latest server log

https://paste.domicraft.fr/ebajovicug.md

What modules are you using?

No response

What part of TNE is the bug affecting?

Transactions

Is your server using online mode?

Yes

Bug description

When using /money request, the received message cannot be clicked to proceed with the transaction.

Thanks :)

How to reproduce

  1. Use /money request.
  2. Try to click on the message.
  3. Nothing happens.
creatorfromhell commented 1 month ago

TNE Version

0.1.2.9

Spigot Version

1.20.4

Your config.yml

https://paste.domicraft.fr/ekobalogew.yaml

Your latest server log

https://paste.domicraft.fr/ebajovicug.md

What modules are you using?

No response

What part of TNE is the bug affecting?

Transactions

Is your server using online mode?

Yes

Bug description

When using /money request, the received message cannot be clicked to proceed with the transaction.

Thanks :)

How to reproduce

  1. Use /money request.
  2. Try to click on the message.
  3. Nothing happens.

Screenshot of in game with chat?

Aurelien30000 commented 1 month ago

The message is sent as configured (default value), but is not clickable.

image

creatorfromhell commented 1 month ago

The message is sent as configured (default value), but is not clickable.

image

After doing some research and testing, it appears that post-1.19, there's an issue where Mojang blocks certain commands from being run on click... Seems this may have been a casualty of that.

Aurelien30000 commented 1 month ago

Ok thanks for the info.

Anyways it seems to be a problem rather specific to TNE, others work fine. I have also noticed that manually built components seems to work fine: /tellraw @p {"clickEvent":{"action":"run_command","value":"/money pay <player> 10 DD"},"text":"Click to test!"}.

creatorfromhell commented 1 month ago

Ok thanks for the info.

Anyways it seems to be a problem rather specific to TNE, others work fine. I have also noticed that manually built components seems to work fine: /tellraw @p {"clickEvent":{"action":"run_command","value":"/money pay <player> 10 DD"},"text":"Click to test!"}.

Not sure, that was from the changelogs for Minecraft versions and validated through testing on a different version, I'll disable this feature until a fix is in place though.