TheNewNormal / corectl

CoreOS over macOS made very simple
Apache License 2.0
286 stars 21 forks source link

Support for Ignition configs #100

Open crawford opened 7 years ago

crawford commented 7 years ago

While this currently supports cloud-config, there are many things that it cannot properly configure. Ignition solves all of those issues and it would be great if I could provide my configuration as an argument to corectl run. The template Ignition config could use the "append" clause to chain the user-provided config to the template.

AntonioMeireles commented 7 years ago

@crawford hi! great to hear from you, CoreOS ppl ! this has been actually in my and @rimusz' radar for a while, expect support for this, for review, in the next few days.

AntonioMeireles commented 7 years ago

@crawford, ongoing in #101.

Thanks in advance && have a great weekend!

larstobi commented 7 years ago

Is there any reason the pull request hasn't been merged yet? :-)

AntonioMeireles commented 7 years ago

Hi, just time, or lack of it, the need of a rebase and some extra tweaks. Will try to get this in this weekend.

On Fri, 27 Jan 2017 at 08:53, Lars Tobias Skjong-Børsting < notifications@github.com> wrote:

Is there any reason the pull request hasn't been merged yet? :-)

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/TheNewNormal/corectl/issues/100#issuecomment-275617111, or mute the thread https://github.com/notifications/unsubscribe-auth/AAtYZzbeOP-oNjF1zBly-xJJScf4hxaJks5rWbChgaJpZM4KwDay .

larstobi commented 7 years ago

Okay, that sounds great!

Let me know if I can help with testing, as I am pretty keen on this feature. 👍

larstobi commented 7 years ago

This feature would be awesome! The lack of ignition support is currently preventing testing ignition configs on a laptop with corectl, so I am eagerly awaiting this. :-) 👍

larstobi commented 7 years ago

@AntonioMeireles Have you been able to get some work done on it? :-)