search

TheNexusAvenger / Nexus-VR-Character-Model

Maps Roblox characters to the VR inputs of players.
MIT License
67 stars 12 forks source link

Fix nested things inside of Tools from going transparent #33

Closed karl-police closed 10 months ago

karl-police commented 10 months ago

Additionally make it check for that... 🤷

karl-police commented 10 months ago

Changed it

TheNexusAvenger commented 10 months ago

Formatting looks fine. There is another change I'll make later once this gets merged. For testing, what structure of instances does this solve for? Is it any part within a tool for any parent?

karl-police commented 10 months ago

Formatting looks fine. There is another change I'll make later once this gets merged. For testing, what structure of instances does this solve for? Is it any part within a tool for any parent?

It just gets the first ancestor of the "Tool" class. It should prevent any part that is inside a Tool, from going transparent.

karl-police commented 10 months ago

Formatting looks fine. There is another change I'll make later once this gets merged. For testing, what structure of instances does this solve for? Is it any part within a tool for any parent?

Tool > Handle Tool > Folder > Part

would have to weld Handle to Part

prevents "Part" from going invisible

I haven't tested this yet though, but it's a simple theory, worth testing though I just ask people for testing.

This one is more interesting https://github.com/TheNexusAvenger/Nexus-VR-Character-Model/pull/35

TheNexusAvenger commented 10 months ago

The pull request is appreciated and the issue can be confirmed, but I am closing this because I have found a different solution with commit cf63f9c7dc75301ce6a33885108150eef6aa8276.

karl-police commented 10 months ago

The pull request is appreciated and the issue can be confirmed, but I am closing this because I have found a different solution with commit cf63f9c7dc75301ce6a33885108150eef6aa8276.

someone confirmed that it is fixed now, yes