TheNexusReborn / NexusIssues

Reporting hub for issues on The Nexus Reborn
0 stars 0 forks source link

Players being left alone if they are the last one after someone leaves before the Warmup #12

Open Firestar311 opened 1 year ago

Firestar311 commented 1 year ago

CJ reported that he left and rejoined before the game began and the other player (There was only 2) was the only one left in the game. This can be reproduced and the only way to actively fix it is for the other player to leave and then rejoin as it resets it back to the lobby.

I did some investigating and found that CJ was kicked due to "Flying is not enabled" so must have gotten stuck before the teleportation, I might change this to prevent this kind of issue, but that is a completely different problem, and the issue here is reproducible by manually doing it.  Game ID 148 was the first one that it happened on, and I had to look through the server logs to actually see what was up.

The proper way to fix this is to add a check for this during the stages before the warmup begins and just reset back to the lobby. I have already begun this work for the new GamePhases system and as I import the progress to this new system, I will be using this check. This commit here is where it was originally implemented: 8de41a7 Doing it this way also prevents the game from being saved to the database, which is a good thing because it really isn't a game.

cjkdawg commented 1 year ago

@Firestar311 I got kicked for flying because I was spamming doors below me, thats how I found it but you can leave manually and join back and the glitch will still work.

Firestar311 commented 11 months ago

Apparently applies to Deathmatch warmup as well

Firestar311 commented 10 months ago

The auto-kick issue that is most common with triggering this bug has been addressed by changing the server.properties as well as reworking how spawns are handled in the game. You can see #13 for more information. Still working on the main fixes for this problem though