search

TheNinza / dsa-visualizer

https://dsa-visualizer.vercel.app
MIT License
2 stars 11 forks source link

changed the Logo! #11

Closed Sanket2055 closed 3 years ago

Sanket2055 commented 3 years ago

changed the logo from institute logo to this , if u think this pr is appropriate please merge it and add the label hacktoberfest-accepted thank you !!

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @TheNinza on Vercel.

@TheNinza first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theninza/dsa-visualizer/HfErhXZkQF3nzce3TNYN9Gmueyeh
✅ Preview: https://dsa-visualizer-git-fork-sanket2055-logo-theninza.vercel.app

TheNinza commented 3 years ago

@Sanket2055, The color scheme of the logo must resemble the color scheme of the website. So It would be great if you can change it. Also DON'T host the logo somewhere else. Add it in src/assets folder

Sanket2055 commented 3 years ago

@Sanket2055, The color scheme of the logo must resemble the color scheme of the website. So It would be great if you can change it. Also DON'T host the logo somewhere else. Add it in src/assets folder

thanks for the reply sir , so should i change the text color inside the logo to violet -blue(same as the navbar ) or should i also change the icon (orange one ) to other icon and text formatting . thank you!

TheNinza commented 3 years ago

@Sanket2055 you don't need to be this much formal :) . Keep the conversation simple. speaking of changes, whatever you add must follow the theme... that's all.

Sanket2055 commented 3 years ago

@Sanket2055 you don't need to be this much formal :) . Keep the conversation simple. speaking of changes, whatever you add must follow the theme... that's all.

okay sir

TheNinza commented 3 years ago

hey @Sanket2055 , There is a conflict due to the last merge... resolve that too...

Sanket2055 commented 3 years ago

Hello @TheNinza sir , what do u think about this logo

TheNinza commented 3 years ago

hey @Sanket2055 , sorry for the delay from my side. Yes the logo looks good. Make sure you resolve the conflicts before making the pr.

Sanket2055 commented 3 years ago

@TheNinza sir , please review this, I have added the logo ( resolved the conflicts )

Sanket2055 commented 3 years ago

@TheNinza sir , in case of height=70 the logo was getting overflowed in responsive mode , height 64 seemed perfect so changed it to 64.

Sanket2055 commented 3 years ago

@TheNinza sir can u please add the label hacktober-fest accepted to this PR , Thank you!

TheNinza commented 3 years ago

@Sanket2055 already did

Sanket2055 commented 3 years ago

@Sanket2055 already did

ohh okay sir, it was showing label as none .that's why i asked