TheNitesWhoSay / Chkdraft

An open-source map editor based on Scmdraft.
MIT License
39 stars 15 forks source link

[Bug] Remastered Skins: some objects or part of them are displaced or missing #188

Open AleXoundOS opened 2 months ago

AleXoundOS commented 2 months ago

First of all, I'm very grateful to your amazing work on supporting the skin selection! It's really cool! But it seems there are a few bugs.

Remastered SD: correct placement (for reference): myscr_2024-09-09T03:35:04+04:00

Remastered HD2: yellow start location and map revealers are displaced (not sure about Zerglings) myscr_2024-09-09T03:35:06+04:00

Remastered Carbot HD2: Tank's turret is displaced (not sure about Zerglings) myscr_2024-09-09T03:35:08+04:00


"Remastered SD" skin does not suffer these problems, except when a unit like Goliath or Tank is selected in the left side unit selection panel - only its bottom part is shown using all skins except "Classic GDI". But when placed (by left-clicking a mouse) all parts of a unit are fully shown (but some are displaced like Tank's turret).

TheNitesWhoSay commented 1 month ago

Just FYI/why this is delayed and not addressed in the version I'm releasing today/tomorrow: turrets and (at least partially) unit offsets are controlled by iscripts (broadly under the animation feature), anything I have in chkdraft for them at present is a quick hack rather than proper iscript parsing & handling. Animation/iscript parsing is coming and is currently the highest priority feature under development but it's still a ways from being ready when it's further along I'll ensure these issues are addressed.

AleXoundOS commented 1 month ago

Do you want to say that location displacement (yellow on screenshots) is also affected by animation/iscript parsing?