search

TheNoim / fastify-loader

The route loader for the cool kids!
MIT License
17 stars 0 forks source link

An in-range update of fast-glob is breaking the build 🚨 #19

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

The dependency fast-glob was updated from 3.1.1 to 3.2.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

fast-glob is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build could not complete due to an error ([Details](https://travis-ci.org/TheNoim/fastify-loader/builds/650791246?utm_source=github_status&utm_medium=notification)).
Release Notes for 3.2.0

💬 Common

  • An empty pattern now causes an error (#247)

🚀 Improvements

In the #156 issue we've redesigned the deep filter, which controls the reading of directories in depth.

Previously, this filter did not take into account positive patterns and only used their maximum depth. For example, the example below shows how many extra directories we read:

{src,fixtures}/**

src → read
fixtures → read
out → read
node_modules → read

Now we apply positive patterns.

{src,fixtures}/**

src → read
fixtures → read
out → skip
node_modules → skip

Synthetic benchmark

{fixtures,out}/{first,second}/*

sync, ms async, ms stream, ms
3.x.x 13 22 20
3.2.0 5 9 8

{fixtures,out}/**

sync, ms async, ms stream, ms
3.x.x 37 49 52
3.2.0 6 10 12

Real world benchmark

  • Globby
  • Prettier
  • {blocks-*,construct}/**/*.styl (a very large project) 13s → 0.16s

Known issues

  • For some cases, there is a noticeable slowdown of 3-6%.
  • Patterns containing {a..z} (or similar) may introduce some slowdown.

We will work on this in the future.

🎉 Thanks

  • @jonschlinkert for the scan method in picomatch that returns parts of the pattern.
  • @fisker for early beta feedback.
Commits

The new version differs by 23 commits.

  • 1757299 3.2.0
  • 27ab96c Merge pull request #252 from mrmlnc/ISSUE-156_improve_partial_matcher
  • 3c33e23 fix(matchers): pass settings to "isDynamicPattern" method
  • 087c51e test(utils/pattern): add more tests for "isDynamicPattern" method
  • 9444563 refactor(utils): drop unused code
  • f043c84 fix(matchers): correctly handle multiple patterns
  • 6474bf4 fix(matchers): correctly handle pattern with difference levels
  • 0923f9b Merge pull request #249 from mrmlnc/ISSUE-156_partial_matcher
  • d16282c Merge pull request #250 from mrmlnc/ISSUE-247_input_data_validation
  • d5bd15f feat: improve input data validation
  • 2f5f18e refactor(matcher): extract base methods to the abstract class
  • 0d2ee18 test(smoke): add smoke tests for partial matching
  • c884233 build(package): add benchmark for partial matching
  • aefa86d feat(utils/pattern): add method to match pattern parts
  • 8cef9e8 refactor(providers): introduce matchers

There are 23 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 3.1.1 your tests are passing again. Downgrade this dependency 📌.

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for 3.2.1

💬 Common

  • Temporary fix for #253.
Commits

The new version differs by 4 commits.

  • 78c7780 3.2.1
  • f9af597 refactor(utils): use picomatch instead of micromatch to scan a pattern
  • 60d2d27 Merge pull request #255 from mrmlnc/ISSUE-253_avoid_yarn_error
  • 69be6a2 build(package): add picomatch dependency

See the full diff

greenkeeper[bot] commented 4 years ago

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for 3.2.2

🐛 Bug fixes

  • Fix a problem with patterns with leading dot segment (like ./… or .\\…) (#257)
Commits

The new version differs by 9 commits.

  • 5d1ac28 3.2.2
  • feee3bd Merge pull request #258 from mrmlnc/ISSUE-257_fix_patterns_with_leading_dot
  • abe17b6 refactor(filters): use utility instead of regex
  • 8851e0f refactor(utils): add leading dot segment removal utility
  • 2466aea fix(filters/deep): fix a problem with matching for patterns with leading dot
  • 78c7780 3.2.1
  • f9af597 refactor(utils): use picomatch instead of micromatch to scan a pattern
  • 60d2d27 Merge pull request #255 from mrmlnc/ISSUE-253_avoid_yarn_error
  • 69be6a2 build(package): add picomatch dependency

See the full diff