TheNouillet / symfony-vscode

Symfony extension for Visual Studio Code
MIT License
20 stars 23 forks source link

the plugin does not initiate #26

Closed zskiredj closed 5 years ago

zskiredj commented 5 years ago

the plugin does not work.

It stays stucked on "Symfony is reading".

I have used : "symfony-vscode.phpPath": "C:/wamp/bin/php/php7.1.26/"

Any idea why ?

TheNouillet commented 5 years ago

Hello,

A new version of the extension has been pushed. Try upgrading and tell me if any error message showed up.

2 possibilities :

zskiredj commented 5 years ago

Indeed the extension works on mac, but not on Windows.

I installed it in a mac and windows 7 with same project. It works on mac but not on windows.

When do you think it will be available for windows?

Thanks in advance.

smertelny commented 5 years ago

Had the same problem on Windows 10, fixed by changing src/symfony/ComposerJSON file from let composerObj = JSON.parse(fs.readFileSync(uri.path).toString()); to next let composerObj = JSON.parse(fs.readFileSync(uri.fsPath).toString()); Don't have much time for a proper PR. If I will have time - will make it (if it will be needed). But I can't test this on Mac.

zskiredj commented 5 years ago

when you say

src/symfony/ComposerJSON

, is it in the vendor folder, or somewhere else ?

can you give the path of this file for symfony 3.4 ? thanks in advance

smertelny commented 5 years ago

when you say

src/symfony/ComposerJSON

, is it in the vendor folder, or somewhere else ?

can you give the path of this file for symfony 3.4 ? thanks in advance

The problem is - that is the path in VS Code extension. So you just need to wait for a path or dig into extension code on your local machine

TheNouillet commented 5 years ago

Hello

@smertelny 's PR has been merged, along with additional fixes. You can update your extension and see if it works.