search

TheNouillet / symfony-vscode

Symfony extension for Visual Studio Code
MIT License
20 stars 22 forks source link

Get php executable path from "php.validate.executablePath" #34

Open smertelny opened 5 years ago

smertelny commented 5 years ago

Rather a proposal than an issue. I have configured the path to php executable with "php.validate.executablePath" in settings, but extension need to get it from it's own "symfony-vscode.phpExecutablePath". Is there is any reason not to look for the first option before looking for own settings?

TheNouillet commented 5 years ago

Hello,

The reason behind the separate setting is for installations that have the project running on another environnement than the one VSCode is running on (eg : Docker, Vagrant, remote server etc...)

That said, having it on null by default and looking at php.validate.executablePath first is a good idea. I'm all for it.