TheOdinProject / css-exercises

MIT License
1.54k stars 63.54k forks source link

Bug - : Intro to CSS: desired-outcome.png image does not properly illustrate desired CSS outcome #559

Open depleur opened 3 weeks ago

depleur commented 3 weeks ago

1. Description of the Bug: In the Grouping Selectors module of the foundations folder, the desired-outcome.png file (and thus the README.md image) does not correctly convey the bold weight of the first button.

2. How To Reproduce:

  1. Clone the repo.
  2. Go to the foundations folder.
  3. Open the image titled desired-outcome.png in the folder 03-grouping-selectors.
  4. Compare the given image with the buttons after the intended CSS is applied to them.

3. Expected Behavior:

The first button should look boldened.

4. Desktop/Device:

5. Additional Information:

Firefox does not show the black borders around the second button either, but that is fixed when browsing on a Chromium based browser, so I'm guessing that is a compatability issue with Gekko and/or Firefox.

sdobron-1 commented 1 week ago

I do not see this behavior on my machine.

Device: Lenovo X1 Carbon 6th Gen. OS: Linux Mint 21.3 Cinnamon Browsers: Firefox 127.0.1, Chromium 126.0.6478.114

Firefox displays the the buttons slightly different, but text is bold and for all intents and purposes of the exercise is accurate. Please share your code as incorrect code would explain the lack of bold text on your end.

Screenshot from 2024-06-22 19-44-19

depleur commented 1 week ago

desired-outcome

This is what I meant by the image being a little misleading. For me, the desired-outcome.png file is the one that is wrong. Nothing to do with code.

MaoShizhong commented 1 week ago

Funnily enough, #355 had the bold property added because the author believed the image showed bold text for the first element.

When you compare actual bold text, it does not match the image. Therefore, @depleur I'll assign you to undo the changes made by that PR (i.e. remove the bold requirement, and relevant css).

depleur commented 3 days ago

@MaoShizhong I've submitted a PR to close this issue.