TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.88k stars 13.23k forks source link

Foundations - Intro to CSS: iframe in `Lesson overview` not working #25984

Closed DariaNico closed 1 year ago

DariaNico commented 1 year ago

Describe your suggestion

The iframe tag for the Scrim under Lesson overview is showing up as a black box within the lesson. Iframe-issue

Piece of code with the issue

<iframe src="https://scrimba.com/scrim/co12d4cf99cf2776f19e84a9d?embed=odin,mini-header,no-sidebar,no-next-up" sandbox="allow-scripts allow-same-origin allow-popups" width="100%" height="400"></iframe>

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-intro-to-css

Checks

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

01zulfi commented 1 year ago

@theodinproject/foundations can someone with knowledge of scrims look into this please

thatblindgeye commented 1 year ago

I'm not noticing this issue:

image

That said, we do plan on moving these Scrims as additional resource links rather than planted in the middle of lessons. If others are seeing this issue we can expedite this particular lesson, though.

suzuhe481 commented 1 year ago

It looks like the black box is related to whether the user has third party cookies enabled or not. Specifically, for the https://scrimba.com/ domain.

I also have this issue on Chrome, both in the regular browser and in incognito. But I can see the Scrimba if I enable third party cookies. On Firefox, I can see the Scrimba, but if I add the Scrimba domain to my list of websites to block cookies, the black box appears again.

I've seen this on every Scrimba I've encountered during the Full Stack JavaScript course, but my workaround is to just get the direct link using the inspect tool. I would also just recommend a direct link under the Scrimba. Or some kind of overlay/popup telling the user the Scrimba won't work properly unless third party cookies anre enabled.

ManonLef commented 1 year ago

@TheOdinProject/foundations any thoughts/input on the above issue? It came up in discord a few times as well lately

roy9495 commented 1 year ago

Normally I was able to see it

Capturel

But after disabling the cookies

Capturhe

It was gone

Cahpture

thatblindgeye commented 1 year ago

We should probably fast track this particular lesson to remove the embedded scrimba from its current location, and add it to this lesson's Additional Resources (as a simple link, not embedded). @ManonLef

fabulousgk commented 1 year ago

I am game to do this, in fact I am game to do them all, if that would be any help.

thatblindgeye commented 1 year ago

@fabulousgk for now let's just update this particular lesson, but you're assigned for this one!