TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.39k stars 13.03k forks source link

JavaScript Course, More Testing Lesson: Include a video on dependency injection in the assignments #26391

Open CCeph opened 11 months ago

CCeph commented 11 months ago

Describe your suggestion

The first assignment for this lesson asks people to watch the "mocking" videos from this fun fun function series. Dependency injection is used extensively in this series, but up until this point in TOP, it is never taught. While there is brief mention in the series that fun fun function has a separate video on the basics of dependency injection, some might consider it an unnecessary detour from the curriculum.

Hence, I would like this video to be added to the assignments.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-more-testing

Checks

(Optional) Discord Name

cceph

(Optional) Additional Comments

No response

codyloyd commented 11 months ago

I think this might be worth discussing a bit. Dependency injection is an important topic and should probably be covered somewhere

HOWEVER: I am not sure that assigning another 20minute video here is the best plan. It might be worth finding a shorter article or more straightforward video that simply defines the concept, and then referring to it when assigning the mocking vids.

something like this:

If you haven’t already, watch the ‘mocking’ videos from this series. He refers to the concept of 'dependency injection' quite a bit in this video, so if you're unfamiliar with that concept you might want to read this INSERT-ARTICLE-OR-VIDEO-HERE first.

ManonLef commented 11 months ago

I agree with @codyloyd on this. The testing lesson already has an extreme amount of video content, especially since the fun fun functions video series is so lengthy.

I have a few articles on my own list for this that could be a fit:

ManonLef commented 11 months ago

@CCeph What do you think about the above?

CCeph commented 11 months ago

I read all three articles, and I think the first one is best. It's simple and straight to the point.

I found the second article's dependency injection section to be quite complicated with a lot of jargon. It makes dependency injection look like a complicated scary thing when it is not. The third article is a bit longer, very opinionated, with examples that are a tad more complex.

I also still think that the fun fun function dependency injection can be a good resource if students are told to only watch until 3:50. In 4 minutes, the video explains what dependency injection and uses the same dependency (fetch) that's injected in the mocking series. The student would only be missing the why of using dependency injection, which can be explained in a paragraph.

All in all, I think simpler is better here. In my experience, mocking alone can be a mind bender, so it'd be good if the dependency injection resource is as simple as possible. I'd be happy to either include the first article, or the first 4 minutes of the fun fun function video. What do you think?

github-actions[bot] commented 10 months ago

This issue is stale because it has had no activity for the last 30 days.

CouchofTomato commented 10 months ago

@codyloyd @ManonLef

Can we get an opinion on the last comment please.

github-actions[bot] commented 9 months ago

This issue is stale because it has had no activity for the last 30 days.

ManonLef commented 6 months ago

@CCeph I am sorry this took a while, I've been mostly absent in the past months due to a new programming adventure :).

I still favour the article but I'd be okay with including both as well with the video clearly noted as an alternative and only until the specified time. Since it's been a while, would you still be interested in being assigned this?

CCeph commented 6 months ago

Sounds good! I will look into it hopefully over the next week.

CCeph commented 6 months ago

I created the pull request for it. It is my first one, so I hope it follows all the rules. If it does not, please let me know and I'll update it right away.

github-actions[bot] commented 5 months ago

This issue is stale because it has had no activity for the last 30 days.