TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
10.1k stars 13.53k forks source link

Fetching Data In React: Add resource to Assignment/Additional Resources section #27505

Closed dziubenzo closed 4 months ago

dziubenzo commented 8 months ago

Checks

Describe your suggestion

I would like to suggest adding the following article to the Assignment/Additional Resources section (preferably Assignment):

https://www.developerway.com/posts/fetching-in-react-lost-promises

It's a follow-up to the 2nd Assignment resource and deals with race conditions. It contains very digestible examples, and it was a very good read in my opinion.

However, it mentions useRef(), which is covered later in the curriculum, but that's just one way of solving race conditions, and there are others.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-react-new-fetching-data-in-react

(Optional) Discord Name

dziubenzo

(Optional) Additional Comments

No response

JoshDevHub commented 8 months ago

Thank you for making this issue/suggestion.

I'm not much of a react person, so I'm going to tag our @TheOdinProject/react team and get their thoughts on this.

MaoShizhong commented 7 months ago

EDIT: General reword as I think my original wording may have sounded different to what I intended.

@dziubenzo Thanks for opening this issue.

I think this will be a decent additional resource. We're not currently overloaded on additional resources, and the article does provide some nice diagrams and a little more of a dive into race conditions than the current assignment article (though in terms of what's necessary, I think the assignment article is sufficient actual assigned reading).

I don't think it'll be an issue to add the suggested resource there, along with a note to not worry about the useRef part since that will be covered later on. The latter two options (primarily AbortController) are more appropriate IMO anyway.

Assigning this to you @dziubenzo

github-actions[bot] commented 6 months ago

This issue is stale because it has had no activity for the last 30 days.

mathdebate09 commented 4 months ago

Hey @MaoShizhong, this issue seems to be stale. I would like to work on it. Could it be reassigned to me? We could perhaps wait for some time after this comment, in case the previous assignee responds.

MaoShizhong commented 4 months ago

@dziubenzo checking in to see if this is still something you wish to work on.

dziubenzo commented 4 months ago

@dziubenzo checking in to see if this is still something you wish to work on.

I'll be able to work on the issue in approx. two weeks once I'm done with the Odin-Book project. Sorry for keeping it on the back burner, but I'm really focused on finishing TOP and learning, and it is taking me much more time than I thought. If this matter is something urgent, I have nothing against assigning the issue to @mathdebate09.

MaoShizhong commented 4 months ago

No worries, thanks for getting back to us! Since this is just adding an additional resource and not an urgent matter, I'll leave you assigned @dziubenzo and you can get to it when you can.

Let us know if you run into any issues along the way.