Project: Binary Search Trees - Instructions could be revised

TheOdinProject / curriculum

The open curriculum for learning web development

https://www.theodinproject.com/

Other

9.06k stars 12.55k forks source link

Project: Binary Search Trees - Instructions could be revised #27620

Open MLGabe opened 1 year ago

MLGabe commented 1 year ago

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Exercises: File type incorrect for all test files

The following checkbox is OPTIONAL:

[x] I would like to be assigned this issue to work on it

1. Description of the Bug: The instructions are a little misleading, as it first tells the learner to create a Tree class with an array, but then the array itself is used in a func. This can cause confusing as the approach is different if going for functional or for object oriented, as the tree only needs the root.

CouchofTomato commented 1 year ago

Hi @MLGabe

Thanks for giving us your thoughts. Can you give a bit more insight about what your prposed solution is so we can discuss this further?

MLGabe commented 1 year ago

Sure, I can open a PR with the changes in wording. Would that work?

CouchofTomato commented 1 year ago

Hey @MLGabe

Yes that would be fine but I can't promise it will be accepted until we've seen it.

thatblindgeye commented 4 months ago

@MLGabe checking in on this

MaoShizhong commented 3 months ago

Issue transferred to appropriate repo

github-actions[bot] commented 2 months ago

This issue is stale because it has had no activity for the last 30 days.

thatblindgeye commented 2 months ago

@CouchofTomato do you think this is worth keeping open for others to work on, or could it be closed out?

CouchofTomato commented 2 months ago

@thatblindgeye I've added a help wanted label. I think if nobody has picked it up by the next time it's marked as stale we can close it

github-actions[bot] commented 1 month ago

This issue is stale because it has had no activity for the last 30 days.

kyak15 commented 1 month ago

@thatblindgeye @CouchofTomato Hello! Is there any possibility I can work on this issue?

thatblindgeye commented 1 month ago

@kyak15 yep, you're assigned

github-actions[bot] commented 6 days ago

This issue is stale because it has had no activity for the last 30 days.