TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.25k stars 12.83k forks source link

Revisiting Rock Paper Scissors: <Short description of your suggestion> #28114

Open Slimdaddy254 opened 2 months ago

Slimdaddy254 commented 2 months ago

Checks

Describe your suggestion

  1. If everything goes fine, our rps-ui branch is now successfully merged with main! Use git log and you’ll see all the commits you’ve made to your feature branch on top of the commits you made to the main branch. Now for our final step!

I have realised with the instruction above on git log, there is no instruction for one to press "q" in order to exit git log. Took me a while as a newbie to figure out how to exit git log,but i think it would help if it was there before moving to the next step.

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-revisiting-rock-paper-scissors

(Optional) Discord Name

Shadee

(Optional) Additional Comments

No response

JoshDevHub commented 2 months ago

Hello @Slimdaddy254. Thank you for making this issue.

I think your suggestion is very sensible. Since you indicated you want to work on it, I'll assign you. Let me know if you have any questions.

Slimdaddy254 commented 2 months ago

You can review my commit.

JoshDevHub commented 1 month ago

Hi @Slimdaddy254

Me just looking at a commit you've made on your fork isn't enough to get the change merged into the curriculum. You need to open a Pull Request (or PR) to this repository with your proposed changes. Please see our contributing guide for information on how to do this.