TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.08k stars 12.57k forks source link

Foundations & Javascript (NodeJS): Update Scrim links to newer versions #28259

Closed mathdebate09 closed 1 week ago

mathdebate09 commented 1 week ago

Checks

Describe your suggestion

Scrimba recently had a major update in how their website is managed rendering a lot of links invalid, they do redirect to the newer pages but the links don't seem to work, I've compiled a list of fixes necessary with newer links in the spreadsheet.

If maintainers approve we can start assigning these to contributors, I'll keep the issue updated if they've been assigned/merged by maintainers yet, or not.

Guidance

Progress & Assignees

Foundations

Javascript (NodeJS)

Path

Foundations, Node / JS

Lesson Url

https://www.theodinproject.com/paths/foundations/courses/foundations https://www.theodinproject.com/paths/full-stack-javascript/courses/javascript

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

[Edit: Verbiage/Spell checks]

SumonGFC commented 1 week ago

You can assign me one

theSamyak commented 1 week ago

Hi, I'd like to volunteer for this task. Please assign me a section.

TheSeagullDev commented 1 week ago

I would love to work on a section in foundations.

MaoShizhong commented 1 week ago

Thanks @mathdebate09. I have checked all of the highlighted lessons and their Scrimba links and found all of them automatically redirect to the correct and working Scrimba course, meaning the current links in the lesson (for now) do not actually need to be changed. This is in contrast to one or two previous links that actually did redirect to the wrong course entirely, and therefore those ones had to be changed.

(The proposed link for the Intro to CSS lesson in your spreadsheet actually takes you to a completely different Scrimba from the one the existing link already takes you to. The one the lesson link takes you to is correct).

i.e. I am unable to replicate any actual issue with any of these links on my devices, as they all end up taking you to the correct Scrimba courses. Can others replicate this?

mathdebate09 commented 1 week ago

Yes most of them redirect to v1/v2 links, the thought just occurred to me incase if they in future became inaccessible, rather just update the links for now itself, the links work perfect for me as well.

SumonGFC commented 1 week ago

For reference, the only site that did not redirect me to the v2 site was The Cascade which redirected me to the v1 site

MaoShizhong commented 1 week ago

v1 or v2 won't matter, that's a Scrimba thing. Whether it's v1 or v2 Scrimba, as long as we land on the correct video and that video works, we're happy. A couple of Scrimba links before actually didn't take us to the correct video (IIRC, some took us to some sign up page or some other generic dashboard), so those had to be changed. Since these ones take us to the correct videos, we can leave them. Should this change in the future, someone can open a new issue/PR to replace that broken link

mathdebate09 commented 1 week ago

v1 or v2 won't matter, that's a Scrimba thing. Whether it's v1 or v2 Scrimba, as long as we land on the correct video and that video works, we're happy. A couple of Scrimba links before actually didn't take us to the correct video (IIRC, some took us to some sign up page or some other generic dashboard), so those had to be changed. Since these ones take us to the correct videos, we can leave them. Should this change in the future, someone can open a new issue/PR to replace that broken link

Yes that works the best