Added hash map tests for Ruby

elishamutang commented 1 week ago

Because

Allows users to populate their hash maps where it will exceed their load factor and ensuring that their hash map methods will still work as expected after growing their buckets (similar to this PR for JavaScript course).

This PR

Added a new section to test out user hash map implementation after Assignment section. Added dummy nodes to populate user hash map in the new section.

Issue

Closes #28257

Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project curriculum contributing guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] If this PR addresses an open issue, it is linked in the Issue section
[x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
[x] If any lesson files are included in this PR, they follow the Layout Style Guide

SumonGFC commented 1 week ago

Hello :p Small gripe: In ruby style conventions, the names of "predicate methods" (methods that return a boolean) should end with a question mark to indicate that they return booleans. So on lines 52 and 109 in your proposed changes, #has(key) should be named #has?(key). just wanted to let you know.

elishamutang commented 1 week ago

@SumonGFC Ah i see, didn't know that. Thanks for letting me know, I'll undo that change! What about the the set method in lines 44 & 48?

SumonGFC commented 1 week ago

@elishamutang those lines are perfect. This set method is not supposed to return a boolean in the interface described by this project (think it is supposed to return the value that is associated with the key)

So #has?(key) is the only method that should have the question mark on the end

elishamutang commented 6 days ago

@JoshDevHub totally missed that last #has method haha. No worries and thanks for the help! You too @SumonGFC :)

TheOdinProject / curriculum