TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.08k stars 12.57k forks source link

JS Linting: Remove release version-specific note box #28289

Closed MaoShizhong closed 3 days ago

MaoShizhong commented 3 days ago

Because

ESLint's VSCode extension's release version has now been updated to resolve the issue that one of the Linting lesson's note boxes addresses - now v3.0.10 as of this PR.

The v9 support note box also needs to specify that the Eslint: Use Flat Config setting must be disabled if someone follows that step, else it won't recognise the old eslintrc format.

This PR

Issue

N/A

Additional Information

I really look forward to when ESLint v9 and flat config is widely supported among the community plugins...

Pull Request Requirements

MaoShizhong commented 3 days ago

The linting error is from a missing assignment section. I'll address it as part of the ESM/Webpack rewrite PRs, as that also involves moving template repos away from the lesson.

CouchofTomato commented 3 days ago

There is a linting issue which I'm not sure whether it needs to be addressed. Otherwise it's fine.

MaoShizhong commented 3 days ago

Thanks @CouchofTomato. As per the above comment, I'll address the lint issue in #27962 in due course due to more relevant changes there.