Closed mathdebate09 closed 3 days ago
Should I fix the linting issues as well? The issue mentioned to let them be
For these, I can trust you to address any reasonable lint errors. Most should be fixable using the appropriate npm fix scripts, then if any obvious ones remain, you can manually fix those.
Feel free to ask any questions if you encounter any less clear lint errors.
Yes they were really easy fixes, but the linter still screams, it requires a section on lesson overview, can i work on it as well? Also there's an error which didn't make sense to me
It's a Knowledge Check
section which is always written with h3, should i change it to h4 as per the linter?
Edit: I forgot to ask for another change i made, in the ruby_on_rails/mailers_advanced_topics/websockets_and_actioncable.md
file, there were clashing headers with both having title as Connections (lines 63
and 104
), I've made them a bit more descriptive and thus no clashing links and updated link in Knowledge Check as well.
I believe this should do it, also I moved the Conclusion
up, right before Assignments
section to adhere to the lesson structure.
Because
Revise the link texts as per the instructions given in the issue.
This PR
Issue
Related to #28290
Additional Information
nil
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section