TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.86k stars 13.21k forks source link

asset_pipeline.md: Removed a outdated learning objective #28295

Closed samyuii closed 3 months ago

samyuii commented 3 months ago

Removed a outdated learning objective - How to display raw HTML code in asset_pipeline.md in reference to issue #28064

Because

This PR removes an outdated learning objective from the "Ruby on Rails - The Asset Pipeline" lesson. The objective referenced displaying raw HTML code in the app, but this section was removed from the lesson content in the past. This update ensures the curriculum accurately reflects the current lesson structure.

This PR

Issue

Closes #28064

Additional Information

Pull Request Requirements

samyuii commented 3 months ago

Thanks for doing this, @theSamyak.

If you're happy to fix the rest of the linting errors, you can best do this by working with a local clone of your fork and branch since there are so many, where you can follow our local linting instructions. Two passes of the fix:lesson script should result in one h3/h4 error left that can only be fixed manually.

Let me know if you're comfortable doing this. If so, go ahead and hit the "re-request review" button as shown below to let me know when you're done with those fixes. Feel free to ask any question if you run into issues.

image

Conversely, if you're not comfortable with fixing these here, let me know and I'll be happy to merge this PR as is, since it does resolve the linked issue. The lint errors can be solved separately another time.

Hi @MaoShizhong ,

Thank you for the clear instructions. I would gladly fix the remaining linting errors. I'll follow your suggestions and re-request a review when I'm done. You can merge this PR as it would be more efficient for me to work on a separate branch dedicated to resolving these issues.

I plan to start working on this by tomorrow or the day after. If I encounter any issues, I'll reach out for guidance. I hope you have a great day!

MaoShizhong commented 3 months ago

Sure thing. I'll merge this one, then you can work on a separate PR for the remaining lint issues. In that PR, you can add Related to #28295 in the PR form to provide context for it.

samyuii commented 3 months ago

Sure thing. I'll merge this one, then you can work on a separate PR for the remaining lint issues. In that PR, you can add Related to #28295 in the PR form to provide context for it.

Gotcha! Thanks for merging this PR!