TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.63k stars 13.07k forks source link

Setting up Git: homebrew prompts next steps on intel based mac #28512

Open fadingmorsecode opened 1 month ago

fadingmorsecode commented 1 month ago

Checks

Describe your suggestion

Relevant text begins on LINE 74 (lesson-note--warning)

On an Apple Silicon Mac, you will have an extra step to take. If you look at the terminal output after installing Homebrew, you will see “Installation Successful!”. Further down in the terminal, there will be a section called “Next steps”.

The instructions of STEP 1 say that the terminal will print a “Next steps” section that is exclusive to Apple Silicon Macs. I am using an intel based Mac and that section is being printed despite what the lesson is indicating.

Screenshot 2024-07-26 at 6 39 46 AM Screenshot 2024-07-26 at 6 55 46 AM

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-setting-up-git

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

MaoShizhong commented 1 month ago

@xandora Any thoughts on this?

xandora commented 1 month ago

This feels like something that goes back and forth. It wasn't in the Apple Silicon script, then it was, then it wasn't in the Intel script...

If Intel macOS users are seeing this message, then we can likely just drop this section or remove the note part and just make it more of a generic instructional step.

fadingmorsecode commented 1 month ago

My vote is making it more generic and saying to make sure to complete additional steps if present. Kinda just future proofs it if there are switch ups.