TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
10.03k stars 13.44k forks source link

Foundations: Object Basics: Bad Filter-Map-Reduce Visual #28696

Open ruben-vl opened 2 months ago

ruben-vl commented 2 months ago

Checks

Describe your suggestion

In the Object Basics lesson of the Foundations course, there is a visual for the filter/map/reduce array methods.

This image has some problems:

Possible solutions:

  1. remake the diagram with some better pictures, proper centering, and a higher quality export (+ reference to the 'inspiration image' ofcourse)
  2. replace with a better visual for these three methods (+ reference)
  3. remove the image and provide a textual summary

I think option 2 is best, with option 3 as fallback, but I would love to hear your suggestions! I also wouldn't mind working on this, but if someone else is eager to work on a simple issue, by all means go ahead! :)

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-object-basics

(Optional) Discord Name

ruben-vl

(Optional) Additional Comments

No response

MaoShizhong commented 2 months ago

Wouldn't be opposed to a higher resolution and neater equivalent, whether that's an alternative image we can attribute or a custom made one.

If you'd like to work on this, I can assign it to you. Handling images in lessons is a 2-PR process - one to replace the image file, a second to replace the CDN link for the image in the appropriate lesson, and any other alt text etc.

mathdebate09 commented 2 months ago

If OP doesn't have bandwidth rn, I can take this issue up

ruben-vl commented 2 months ago

If OP doesn't have bandwidth rn, I can take this issue up

Go ahead, I don't have much time for it atm.

MaoShizhong commented 2 months ago

Cheers both. Assigned, @mathdebate09

mathdebate09 commented 2 months ago

objects

Res: 1780 x 1200

Made this using figma, let me know if any changes would be needed, or else i can submit a pr

Edit: Figma Link

github-actions[bot] commented 1 month ago

This issue is stale because it has had no activity for the last 30 days.