search

TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
9.87k stars 13.21k forks source link

feat(mdlint): improve error message for TOP005 #28782

Closed nikitarevenco closed 3 days ago

nikitarevenco commented 2 weeks ago

Note: Making this PR to test if this will even work, only review if it's not marked as draft

image

MaoShizhong commented 2 weeks ago

A heads up if you just want to test or experiment with something like this first, please PR in your own fork, as opposed to testing out in the upstream repo. You can then open a new PR from that branch to upstream main if you decide it's appropriate.

nikitarevenco commented 2 weeks ago

A heads up if you just want to test or experiment with something like this first, please PR in your own fork, as opposed to testing out in the upstream repo. You can then open a new PR from that branch to upstream main if you decide it's appropriate.

thanks for the tip!

It's ready for review now

nikitarevenco commented 2 weeks ago

image

nikitarevenco commented 4 days ago

Ok so I'll use my computer to edit the code and test it instead of relying on github's code editor, this approach only works well for documents

nikitarevenco commented 4 days ago

I fixed it, the tests are passing now

nikitarevenco commented 3 days ago

Nit again sorry - can the strings be handled via template literals instead of concat/increment? Same reasoning as before - consistency of approach (in file and between files).

Of course!