<Advanced HTML and CSS>: <Inconsistent link leads to download instead of opening in browser>

TheOdinProject / curriculum

The open curriculum for learning web development

https://www.theodinproject.com/

Other

10.11k stars 13.54k forks source link

<Advanced HTML and CSS>: <Inconsistent link leads to download instead of opening in browser> #28796

Open leah205 opened 2 months ago

leah205 commented 2 months ago

Checks

[X] This is not a duplicate of an existing issue (please have a look through our open issues list to make sure)
[X] I have thoroughly read and understand The Odin Project Contributing Guide
[ ] Would you like to work on this issue?

Describe your suggestion

In the Project: homepage section both the tablet and mobile design files open in a new tab while the desktop file is downloaded.

Path

Ruby / Rails, Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-advanced-html-and-css-homepage

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

Rajaravi99 commented 1 month ago

Yes, i checked looks like what you are saying is right. This can be worked upon.

mashazyu commented 1 month ago

@Rajaravi99 , hello!

What is the correct behavior - downloading or opening in the separate tab? And I would like to work on this issue, if it's up for grabs.

Kind regards, Maria

Rajaravi99 commented 1 month ago

@mashazyu , Hello I agree, there should be singularity in how various links open on any webapp. According to me the correct behavior should be opening in a separate tab. But lets wait for, what the project owners have to say about this.

MaoShizhong commented 2 weeks ago

Thanks for reporting this. It seems the larger file size for the desktop image is what's causing our CDN to serve it as a downloadable stream instead of just an image like with the other two. This can be resolved by replacing the desktop image and link with a compressed version (smaller file size).

Acceptance criteria

This is a 2 PR process as per our instructions for adding/replacing curriculum images.

[ ] The desktop image is replaced with a smaller file size version (provided below).
[ ] The relevant link href in the project spec is replaced with the new image's Statically link.

Please comment below if you'd like to be assigned to this issue. Please do not open a PR unless you have been assigned by a maintainer.

Compressed desktop image:

Rajaravi99 commented 2 weeks ago

Hi, I am happy to work on it. You can assign it to me.