TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
10.11k stars 13.54k forks source link

Testing Practice: Explicitly state difference from example #28954

Closed nekosoffy closed 1 month ago

nekosoffy commented 1 month ago

Because

I think that for the benefit of clarity, if what the assignment proposes is different from the reference that is linked, it should be stated explicitly to leave no ambiguity if it was intentional or an oversight.

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

linkonsat commented 1 month ago

I think that could make it a bit more confusing. The instructions specify what the conditions to follow and an example. It came off as a bit confusing to add that to me as I could see someone reading it and being confused if they were supposed to use the link for the first cipher test. As they should get the same result as the examples below the article and they would benefit from asking how to achieve it on the Discord. I do appreciate it however!