TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
10.11k stars 13.54k forks source link

Form Validation with JavaScript: Change to questions in Knowledge Check #28969

Closed Meltasy closed 3 weeks ago

Meltasy commented 1 month ago

Checks

Describe your suggestion

The Knowledge Check section states ... "The following questions ...", yet all but one of them are actually written as questions. Do you think we should amend them all to be written as questions? Also, I wonder whether we should remove the last question, because I think it would have already been answered in the first question, or am I missing something?

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-javascript-form-validation-with-javascript

(Optional) Discord Name

Meltasy

(Optional) Additional Comments

Issue #27279 is about refactoring the section which contains this lesson, so I'm not sure if you would want to hold off on this issue and address it at the same time as that issue.

MaoShizhong commented 1 month ago

Assigning you to rewrite the KC questions as actual question (which they should be of course). And yes, you can remove the last one since it's redundant because of the second KC question.

Meltasy commented 4 weeks ago

Thanks, I'll get on to that now :-)

Meltasy commented 4 weeks ago

Done :-)