JS Basics- Problem Solving: Fix incorrect interpretation - Githubissues

TheOdinProject / curriculum

The open curriculum for learning web development

https://www.theodinproject.com/

Other

10.11k stars 13.54k forks source link

JS Basics- Problem Solving: Fix incorrect interpretation #29049

Closed bhagyeshsp closed 1 week ago

bhagyeshsp commented 2 weeks ago

The current explanation tells that the loop continues until the value of i is greater than the value of answer. But in fact, the parameter condition is i <= answer. Hence, the correction.

Because

The incorrect interpretation of i <= answer condition is fixed.

This PR

Replaced only a few words in the same line

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project curriculum contributing guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[ ] If this PR addresses an open issue, it is linked in the Issue section
[ ] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
[ ] If any lesson files are included in this PR, they follow the Layout Style Guide

MaoShizhong commented 1 week ago

The current wording is correct. The condition part of a loop tells us the condition that the loop keeps going. So i <= answer means "keep looping while i is less than or equal to answer" which is the same as "loop until i is greater than answer".

bhagyeshsp commented 1 week ago

Oops! Apologies for raising the false flag. I will have to double-triple check before raising the PR in the future. Thanks for the explanation.