TheOdinProject / curriculum

The open curriculum for learning web development
https://www.theodinproject.com/
Other
10.12k stars 13.56k forks source link

A Deeper Look at Git: <Change Knowledge check Q1 to a question and update links to material covered in lesson> #29108

Open Meltasy opened 20 hours ago

Meltasy commented 20 hours ago

Checks

Describe your suggestion

In the Knowledge check section Q1 should be a question, e.g. What does it mean for branches to be pointers? Also, the links take us to pages on git-scm that aren't covered in the lesson, so I'd suggest changing them to links on the same page, e.g Q1: para headed 'Branches are pointers'; Q2: para headed 'Changing the last commit'; and Q3: para headed Changing multiple commits. Finally, it would make more sense to move Q1 to the bottom of the list of questions as it's covered at the end of the lesson.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/javascript-a-deeper-look-at-git

(Optional) Discord Name

Meltasy

(Optional) Additional Comments

No response

JoshDevHub commented 18 hours ago

Hello @Meltasy and thank you for raising this issue.

Every point you've brought up makes perfect sense to me. I'll assign you to work on the PR :rocket:

Meltasy commented 1 hour ago

Thanks, I've made the changes. Please note that I also removed the extra space in the Assignment list - Mao had told me to do this previously as it's TOP style. Please let me know if that's OK. Have a lovely day :-)