Foundations: Fix the given example on Fibonacci series in README.md of Javascript exercise(Fundamentals: Part 5)

RushilJalal commented 1 year ago

Describe your suggestion

There is a typo where the given Fibonacci series example in the README.md file says:

A series of numbers in which each number ( Fibonacci number ) is the sum of the two preceding numbers. The simplest is the series 1, 1, 2, 3, 5, 8, etc. After completing the exercise, I checked the solution to find that 0 was taken to be the first term of the series. I googled it and confirmed that Fibonacci series starts from 0. I am attaching required screenshots.

Path

Foundations

Lesson Url

https://www.theodinproject.com/lessons/foundations-fundamentals-part-5#assignment

Checks

[X] I have thoroughly read and understand The Odin Project Contributing Guide
[X] Would you like to work on this issue?

(Optional) Discord Name

willyWonka

(Optional) Additional Comments

This is my first time contributing here so any help will be appreciated!

RushilJalal commented 1 year ago

I'm wondering why no one has been assigned to this issue yet. Am I missing something? Should I create a PR without being assigned the issue yet or should I wait?

thatblindgeye commented 1 year ago

@RushilJalal This sounds like this is an issue for our JavaScript exercises repo. If you'd still like to work on it I can assign you, then I'll transfer this issue to that repo.

RushilJalal commented 1 year ago

@thatblindgeye Hey. Yes, I would love to work on it but I'm kinda new to this. Is reading the Contributing guide going to be enough?

thatblindgeye commented 1 year ago

@RushilJalal it definitely should be. If you go through that guide and still feel lost, we'd definitely love the input on what can be made clearer, as we want to make contributing as easy as possible for newcomers. I will transfer this issue to the correct repo and assign you now, but if you have any questions about the contribution process feel free to ask!

RushilJalal commented 1 year ago

@thatblindgeye

transferred this issue from TheOdinProject/curriculum

I don't get what this means. Could you please explain? I have another question. In this case I want to be working with TheOdinProject/javascript-exercises. We were earlier required to fork and clone this repo to complete the exercise so I had an existing clone on my machine. In my case, I deleted the pre-existing clone and made a new one since the old one had my completed exercises. In another case, what if I was still doing the exercises and couldn't delete the clone on my machine? What would have been the best case to go forward with making the fix without causing problems. Sorry I'm just new to this.

RushilJalal commented 1 year ago

The title of the PR must follow the format described in the PR template. I found this in the Contributing Guide but I didn't find anything in the template related to the PR title.

thatblindgeye commented 1 year ago

I don't get what this means. Could you please explain?

That just means the issue was moved from one repo to another.

have another question. In this case I want to be working with TheOdinProject/javascript-exercises. We were earlier required to fork and clone this repo to complete the exercise so I had an existing clone on my machine. In my case, I deleted the pre-existing clone and made a new one since the old one had my completed exercises. In another case, what if I was still doing the exercises and couldn't delete the clone on my machine? What would have been the best case to go forward with making the fix without causing problems. Sorry I'm just new to this.

Typically if you already have a clone you don't need to delete + re-clone. Depending where you're at in the curriculum it may not have been covered yet, but utilizing branches would be the way to go in the future. If you haven't gotten to that point yet don't worry, I believe it comes up in the Revisiting Rock Paper Scissors lesson in Foundations.

RushilJalal commented 1 year ago

@thatblindgeye Actually, using branches has already been covered but I think it makes sense to use branching when you want to add a feature which you don't to be a part of main branch yet. But in my case, if I created a branch, it would consist of the exercises I completed earlier, right? How do I make sure that the clone I'm working with doesn't have the exercises completed by me?

thatblindgeye commented 1 year ago

@RushilJalal It depends what exactly your local clone looks like. If you didn't commit your solutions to the exercises then you could create a new branch and commit them on that new branch, or you could stash them. If you committed your solutions locally then you could create a new branch based off your main branch, then revert your main branch prior to your commit.

Though ideally getting into the habit of working on non-main branches is a good one to get used to.

RushilJalal commented 1 year ago

@thatblindgeye Thanks a lot!

TheOdinProject / javascript-exercises