Update leapYears-solution.js - Githubissues

TheOdinProject / javascript-exercises

MIT License

1.28k stars 34.52k forks source link

Update leapYears-solution.js #468

Closed KeshiEmmanuel closed 6 months ago

KeshiEmmanuel commented 6 months ago

made an arrow function

Because

made it an arrow function

This PR

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[ ] If this PR addresses an open issue, it is linked in the Issue section
[ ] If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

MaoShizhong commented 6 months ago

Thanks for opening this PR @emmdeveloper.

In this situation, we won't be changing any files to use arrow functions, as we would prefer to maintain consistency across all of our exercise and solution files in this repo, all of which use traditional function expressions. Since there isn't a significant reason that they need to be changed into arrow functions, we will be keeping them as they are. Since we won't be making this change, I'll close this PR, but thank you for suggesting it nonetheless.