TheOdinProject / odin-bot-v2

The bot that breathes life into our Discord community
ISC License
48 stars 77 forks source link

new-era-commands: Add new /stuck command #497

Closed MaoShizhong closed 8 months ago

MaoShizhong commented 8 months ago

Because

Since Carlos' great "stuck/working through new concept" flowchart was posted, it has been pinned and linked to many times and has proven very helpful for many learners. To make it easier to link to, a slash command has been made for it.

This PR

Issue

Closes #466

Additional Information

Proof of testing: /stuck command test output

Pull Request Requirements

MaoShizhong commented 8 months ago

EDIT: Ah, I see how Statically works now and that it will require an additional PR following this. Sure thing, I'll get the right link generated and PR it after this is merged.

@wise-king-sullyman wasn't 100% sure exactly how this bot was being hosted and the performance impact of the attachment builder on it in this scenario, but yes, that's what it'd be doing - building the attachment from source each time. I was unable to find another example in this repo of a locally served image being used as an attachment (only party parrot which just links externally hosted gifs).

~~Statically makes sense, though a glance at its docs have proven unhelpful in exactly how I'd need to go about using it from here. I will look into this tomorrow so no need to merge this until I've implemented it. If you are able to provide instructions for exactly how I could use the cdn here to achieve this in the meantime, that would be greatly appreciated. Otherwise I'll have a look at the other repos tomorrow and see how things get used there.~~

MaoShizhong commented 8 months ago

In that case in my first act as a maintainer, I hereby declare this PR merged.