TheOdinProject / ruby-exercises

MIT License
219 stars 1.07k forks source link

incorrect wording hash_exercises #24

Closed subotai54 closed 3 years ago

subotai54 commented 3 years ago

  describe 'update favorite number exercise' do

    it 'returns hash with a new key/value pair when not included' do
      my_favorites = { color: 'blue', number: 65 }
      result = { color: 'blue', number: 65, movie: 'Avengers: Endgame' }
      expect(update_favorite_movie(my_favorites, 'Avengers: Endgame')).to eq(result)
    end

    it 'returns hash with an updated key/value pair when included' do
      my_favorites = { color: 'emerald green', movie: 'Avengers: Endgame' }
      result = { color: 'emerald green', movie: 'Avengers: Infinity War' }
      expect(update_favorite_movie(my_favorites, 'Avengers: Infinity War')).to eq(result)
    end
  end

This is described as favorite number but it calls favorite movie

rlmoser99 commented 3 years ago

@subotai54 Great catch! Thank you for taking the time to submit this issue!