Improve specs for add method (branch main)

TheOdinProject / ruby-exercises

MIT License

219 stars 1.06k forks source link

Improve specs for add method (branch main) #77

Closed edimossilva closed 1 year ago

edimossilva commented 1 year ago

Complete the following REQUIRED checkboxes:

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the location of change: brief description of change format, e.g. Data types exercise: Update spec files

1. Because:

Closes #76

2. This PR:

Add extra specs to add method

3. Additional Information:

I am also creating a PR to the branch solutions

edimossilva commented 1 year ago

@rlmoser99 please review

rlmoser99 commented 1 year ago

@edimossilva This looks great!

Were you also planning to update the specs for subtract, multiply, divide and float_division since they are part of the AC that you wrote on the issue?

edimossilva commented 1 year ago

@edimossilva This looks great!

Were you also planning to update the specs for subtract, multiply, divide and float_division since they are part of the AC that you wrote on the issue?

@rlmoser99 , Yes, do you suggest doing everything in this PR? or should I split into smaller PRs?

rlmoser99 commented 1 year ago

@edimossilva Yes, I think I would prefer to do it all in 1 PR (well technically 2, with the solutions branch).

In this PR, you've used the word "Closes" and linked an issue that you wrote indicating that you intended to update subtract, multiply, divide and float_division. For future reference, if you break each of these up into different PR's then you should say related to the issue. (however, as I stated already, I think it would be best to do it all at once)

Thanks for taking the time to work on this. I will be leaving to go on vacation soon, therefore another maintainer will probably have to review it while I'm gone.

ChargrilledChook commented 1 year ago

Merging this without the requested changes as its been a while