TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.73k stars 2.07k forks source link

Bug: Invalid TheOdinProject email provided #3999

Closed mbiesiad closed 1 year ago

mbiesiad commented 1 year ago

Hi,

Complete the following REQUIRED checkboxes:


1. Description of the Bug: Email message from contact@theodinproject.com constains invalid TheOdinProject email address.

2. How To Reproduce:

  1. Go to https://www.theodinproject.com/sign_up and register in
  2. Open email with welcome message from contact@theodinproject.com titled "Getting started with The Odin Project"
  3. Scroll down to see "(...) or feel free to reach out to theodinprojectcontact@gmail.com." - hover on email address or copy content - see +theodinprojectcontact@gmail.com instead of theodinprojectcontact@gmail.com

3. Expected Behavior: In mentioned place, email address is changed to proper one - theodinprojectcontact@gmail.com

4. Desktop/Device: NA

5. Additional Information: Screenshot: image

image

At this moment this incorrect email address is invalid from Gmail point of view.

Best wishes,

CouchofTomato commented 1 year ago

For anyone that wants to work on this I think the issue is line 229 of this file https://github.com/TheOdinProject/theodinproject/blob/main/app/views/user_mailer/welcome_email.html.erb

I think we need to remove the after mailto: and before the email address.

mbiesiad commented 1 year ago

Thanks for quick reaction. If i may suggest - space after mailto: is redundant. https://github.com/TheOdinProject/theodinproject/blob/main/app/views/user_mailer/welcome_email.html.erb#L229

CouchofTomato commented 1 year ago

Yes, that is what I meant to say 😆 Thanks

mbiesiad commented 1 year ago

FYI: issue fixed, screenshot: image all is fine now 🎉