TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.73k stars 2.07k forks source link

Adopt same `improve lesson/report issue` footer that are in lessons for non lesson pages where appropriate #4061

Closed JustWaveThings closed 1 year ago

JustWaveThings commented 1 year ago

Complete the following REQUIRED checkboxes:

The following checkbox is OPTIONAL:


1. Description of the Feature Request:

Once #4057 is merged, Kevin suggested I make an issue to bring this feature into places that have the old style of 'Improve this lesson on GitHub' footer links. Example: https://www.theodinproject.com/guides/community/before_asking image to: image

2. Acceptance Criteria:

3. Additional Information:

While I checked the box to want to be assigned to the issue because I think I can apply what I learned in the implementation of #4057 to get this to work. However, if someone more capable wants to take it on, I'd happily defer. I am working my way through the node path and without @KevinMulhern and @JoshDevHub's help, I wouldn't have been able to get #4057 done.

ManonLef commented 1 year ago

You've got this!

JustWaveThings commented 1 year ago

Starting on this today. Sorry for the delay.

JustWaveThings commented 1 year ago

So it seems like the community guides a built a bit differently than the lesson content and while I can see the TW classes when I inspect the local instance of the web app, I can't seem to find where they are coming from in the code.

I'd be up for pairing with someone on this who knows a little bit about ruby/rails/TW or throwing it back for someone else to pick up.

Additional note: I found the 'suggest improvements' link is broken (404) for the community guide articles. See Screenshot:

image
JoshDevHub commented 1 year ago

I could probably help you with this some time this week if you want @JustWaveThings

KevinMulhern commented 1 year ago

No worries @JustWaveThings, it's not that obvious with how it's abstracted away behind the container. You're in very capable hands with Josh. If either of you need anything from me, hit me up ✌️

JustWaveThings commented 1 year ago

Sounds like a plan, Josh. Thanks, Kevin!

JustWaveThings commented 1 year ago

Apologize for the delay! I just got TOP running locally again, and hopefully this afternoon or this weekend you have time @JoshDevHub, I'm ready to bang this out and put it to bed.