Open Asartea opened 1 year ago
Squint test suggests this is mostly fine - whatever is closer to the center of the screen has precedence and focus. I think the complete button being larger helps define whats most important. I could see this being a problem if users scroll all the way to the bottom of the page to complete lessons.
This is all kind of subjective though so would definitely like second opinions.
It'd probably be better to have only one "primary" button on the page, though I don't think making one darker would really suffice. We could make one of them a bordered button (to still differentiate it from the "plain" buttons).
We could make one of them a bordered button (to still differentiate it from the "plain" buttons)
What do you mean by bordered button here?
Looks like we're already using those, couldn't tell from the screenshot. The "Learn more" styling is what I meant essentially (not really a button, but styled to look like one). We could update one of the "buttons" to remove the background:
Though in this case "donate now" is probably a little more higher priority than "learn more".
It may not be the biggest issue to keep things as-is, though... Looking at our paths page we'd have to decide if we want to tackle updating the "Select"/"Resume" buttons on that page for each path. But the grouping of the buttons there makes each primary button easily distinguishable from one another.
The buttons are in visually quite different sections, and looking at their size differences makes me believe this is not in need of change perse. I don't think there is much confusion caused here and believe it could stay the way it is.
Going for a dark button looks more out of theme for me here. It gives me the idea of a disabled button in contrast to the other. The order of sections, button size, and section color difference do the trick regarding priority well enough in my opinion.
Complete the following REQUIRED checkboxes:
brief description of request
format, e.g.Add dark mode to website
The following checkbox is OPTIONAL:
1. Description Due to the addition of the new support The Odin Project the footer of lesson pages now contains two primary buttons right after each other, which distracting and makes it harder to clearly see which button is more important. One of these (probably the Donate now) should be changed to a different style (maybe
button--dark
?)With
button--dark
:2. Acceptance Criteria: