Closed thatblindgeye closed 3 months ago
the contributing guide for this repo has had a bit larger of an update, so curious what you think about the state of this scrimba. Like you had said in the original PR I do like how it dives into the web app code itself towards the end, but a lot of the content seems pretty redundant of just going through the contents of the contributing guides and such. We could just have a disclaimer like, "Note that since this scrimba was recorded, some content may have changed in the repo. The focus of this scrimba is less on the actual content, but more of a high level overview." or something.
Thanks @thatblindgeye, that disclaimer sounds good to me. I wouldn't be against removing it entirely if it doesn't add the same value as it did before.
Because
The link text for the scrimba was not descriptive.
This PR
Issue
Closes #XXXXX
Additional Information
@KevinMulhern the contributing guide for this repo has had a bit larger of an update, so curious what you think about the state of this scrimba. Like you had said in the original PR I do like how it dives into the web app code itself towards the end, but a lot of the content seems pretty redundant of just going through the contents of the contributing guides and such.
We could just have a disclaimer like, "Note that since this scrimba was recorded, some content may have changed in the repo. The focus of this scrimba is less on the actual content, but more of a high level overview." or something.
Pull Request Requirements
keyword: brief description of change
format, using one of the following keywords:Feature
- adds new or amends existing user-facing behaviorChore
- changes that have no user-facing value, refactors, dependency bumps, etcFix
- bug fixesBecause
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section