TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.59k stars 2.06k forks source link

Update README.md #4485

Closed thatblindgeye closed 3 months ago

thatblindgeye commented 3 months ago

Because

The link text for the scrimba was not descriptive.

This PR

Issue

Closes #XXXXX

Additional Information

@KevinMulhern the contributing guide for this repo has had a bit larger of an update, so curious what you think about the state of this scrimba. Like you had said in the original PR I do like how it dives into the web app code itself towards the end, but a lot of the content seems pretty redundant of just going through the contents of the contributing guides and such.

We could just have a disclaimer like, "Note that since this scrimba was recorded, some content may have changed in the repo. The focus of this scrimba is less on the actual content, but more of a high level overview." or something.

Pull Request Requirements

KevinMulhern commented 3 months ago

the contributing guide for this repo has had a bit larger of an update, so curious what you think about the state of this scrimba. Like you had said in the original PR I do like how it dives into the web app code itself towards the end, but a lot of the content seems pretty redundant of just going through the contents of the contributing guides and such. We could just have a disclaimer like, "Note that since this scrimba was recorded, some content may have changed in the repo. The focus of this scrimba is less on the actual content, but more of a high level overview." or something.

Thanks @thatblindgeye, that disclaimer sounds good to me. I wouldn't be against removing it entirely if it doesn't add the same value as it did before.