Fix: Sections not being inserted into live preview

TheOdinProject / theodinproject

Main Website for The Odin Project

http://www.theodinproject.com

MIT License

3.72k stars 2.07k forks source link

Fix: Sections not being inserted into live preview #4505

Closed KevinMulhern closed 5 months ago

KevinMulhern commented 5 months ago

Because:

Sections and their ids are being striped out of live previews by Rails sanitiser.

This commit:

Allow sections and ids within live previews

MaoShizhong commented 5 months ago

Would it be good to also add pre here for mermaid diagrams and amy others we use pre for? They don't render properly in the preview. AFAIK codepen stuff requires a script so the other html elements wouldn't really need to be added I don't think

KevinMulhern commented 5 months ago

Theres something else going on with mermaid unfortunately @MaoShizhong. I've been looking into it a little, the pre tags are there, it appears like the mermaid JS isn't firing correctly, I'll probably be making an issue for that soon if I don't get anywhere with it.