Chore - Update twitter.svg

tanmayc43 commented 2 months ago

Updated the old Twitter bird logo to the new "X" logo.

Because

The old twitter bird logo has been long replaced by the new "X" logo and I have done the same on the website to keep it updated and improve the overall user experience.

This PR

The old bird logo SVG file was replaced by the new "X" logo SVG file.
A transform attribute was added to the path section so as to fit the SVG correctly in the required 0 0 24 24 viewbox.

Pull Request Requirements

[x] I have thoroughly read and understand The Odin Project Contributing Guide
[x] The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
- Feature - adds new or amends existing user-facing behavior
- Chore - changes that have no user-facing value, refactors, dependency bumps, etc
- Fix - bug fixes
[x] The Because section summarizes the reason for this PR
[x] The This PR section has a bullet point list describing the changes in this PR
[x] I have verified all tests and linters pass after making these changes.
[x] If this PR addresses an open issue, it is linked in the Issue section
[x] If applicable, this PR includes new or updated automated tests

Asartea commented 2 months ago

Checking it out locally, the icon still seems larger than the other ones.

You'll also want to adjust the fill rules in app/views/shared/_footer.html.erb to account for the new logo having a different color: probably to the same fill rules the GitHub logo has (hover:fill-black dark:hover:fill-white)

tanmayc43 commented 1 month ago

Checking it out locally, the icon still seems larger than the other ones.

You'll also want to adjust the fill rules in app/views/shared/_footer.html.erb to account for the new logo having a different color: probably to the same fill rules the GitHub logo has (hover:fill-black dark:hover:fill-white)

Thank you for your reply!

After rectifying the errors, should i open another pull request and close this one, or is there any method to change my code in this pull request itself?

KevinMulhern commented 1 month ago

@tanmayc43 with this being a direct patch edit PR, opening a new PR is likely best. We get all of our brand svgs from https://simpleicons.org. Using the X logo on there should keep it consistent with our other social media svgs.

We recommend getting the codebase running locally instead of patch editing directly on Github for everything but the simplest of changes. Theres no reliable way to verify what you've done is correct before opening the PR otherwise.

TheOdinProject / theodinproject