TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.55k stars 2.06k forks source link

Feature: Admin v2 Announcement Details Page #4576

Closed KevinMulhern closed 1 week ago

KevinMulhern commented 2 weeks ago

Because:

This commit:

Asartea commented 2 weeks ago

Looks great! 🚀

Played around with it a bit, and a few notes:

(Also: out of the scope of this PR, but on the index "Announcements displayed to everyone on the site as a banner." > "Announcements are displayed to everyone on the site as a banner."

KevinMulhern commented 2 weeks ago

Thanks for the feedback @Asartea, great stuff!

It might be nice to be able to actually mark an announcement as expired, for cases where you want it to stop showing

This is a pretty glaring omission when you point it out haha. I agree it would be very nice to have. I think we'd need to switch to a status instead of relying on the expiry date to do it correctly. That edges it ever so slightly out of scope of this. But I'll put a story together for it.

I've gone ahead and put in the rest of your suggestions though. Thanks again!

KevinMulhern commented 2 weeks ago

Steps for QA

  1. Log into admin v2: admin@odin.com, password123

Creating a new announcement:

  1. Click "Announcements" on the side nav
  2. Click "New announcement" button
  3. Fill in the form and submit
  4. The new announcement should be displayed in the announcements list
  5. Visit the home page - /home
  6. The new announcement should be displayed as a a banner

Editing announcement

  1. Go back to the announcement you just created - click "View" from the all announcements page
  2. Click the "Edit" button
  3. Change the message to: "Edited message" and click save
  4. "Edited message" should be displayed on the homepage banner

Deleting announcement

  1. Go back to the announcement you created once again - click "View" from the all announcements page
  2. Click the "Delete" button
  3. The announcement should be removed from the all announcements page
  4. The banner should no longer be displayed on the homepage
zachmmeyer commented 1 week ago

@KevinMulhern I missed the deployed ODE for this. I can test the functionality when it is available again.

Asartea commented 1 week ago

Played around with it when the deployment was active, and can confirm all the QA steps checked out

KevinMulhern commented 1 week ago

Hey @zachmmeyer, its back up on a review app!

zachmmeyer commented 1 week ago

Thank you @KevinMulhern ! ✅ Test announcement with working hyperlink. ✅ Announcement is persistent on all pages unless cleared with close button image ✅ Text and link change when announcement is edited. image ❌ The message box did not like the entire work of Hamlet. Would be cool to see a character limit. image ✅ Making an announcement and then deleting it deletes the announcement, no longer displaying it.

I'm not sure how long the deployment is live for but I can set the expiration date to the next day and see if it expires, but that's not part of the AC.

KevinMulhern commented 1 week ago

Thanks @zachmmeyer, character limit is a great spot! I've put in a limit of 100 characters - that should hopefully be all we need with the learn more url available.

Review apps are up for 1 day, I can increase that. But I wouldn't worry about QA'ing the expiry, this only adds a new interface for managing announcements to replace our existing one. The code for displaying/hiding expired announcements hasn't changed and been there for years. It's well battle tested 💪

zachmmeyer commented 1 week ago

Then it sounds like we're good to go! image