TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.72k stars 2.07k forks source link

Feature: Admin V2 - Edit team member #4592

Closed KevinMulhern closed 3 months ago

KevinMulhern commented 3 months ago

Because:

This commit:

KevinMulhern commented 3 months ago

Steps for QA: Review app url: https://odin-review-app-pr-4592.herokuapp.com/admin_v2

  1. Log into admin v2 - admin@odin.com, password123
  2. Visit the settings page from the settings link in the left hand corner or from the dropdown in the navbar.
  3. Update your name and email
  4. Update your password
  5. Visit the team page
  6. You're updated name should be displayed in the list
  7. Log out
  8. Use your updated email and password to log in.
Asartea commented 3 months ago

Haven't had time to review everything yet, but preliminary notes:

KevinMulhern commented 3 months ago

I've fixed the issue with the avatar updating - that was due to morphing 😅

But I'm not seeing any freezing. Would you mind tailing your dev logs tail -f log/development.log and posting anything that comes after the patch request the next time it freezes for you please? Anything below the line which includes this:Started PATCH "/admin_v2/profile"

Asartea commented 3 months ago

But I'm not seeing any freezing. Would you mind tailing your dev logs tail -f log/development.log and posting anything that comes after the patch request the next time it freezes for you please? Anything below the line which includes this:Started PATCH "/admin_v2/profile"

Am unable to repro now: going to blame this on just something being weird with my local environment unless proven otherwise

KevinMulhern commented 3 months ago

Nice! thanks @Asartea. It's very possible the fix for the avatar sorted out freezing too. Turbo morphing changes the behaviour of page visits/ form submissions

Asartea commented 3 months ago

QA:

Updating name and email: image image

Updating password: image image

With non matching new passwords: (although could we change the feedback message to something a bit more descriptive? Maybe 'Password and Password confirmation must be the same) image

With wrong current password (same feedback as previous: maybe 'Incorrect password') image

Works on team page: image

Nit: on smaller window sizes the gap between the two containers becomes a bit too small: can we enforce a slightly wider min gap? image

✅ Can successfully sign in with new email + password ✅ Can no longer sign in with old email + password ℹī¸ Have reset the password + email back on review app

KevinMulhern commented 3 months ago

Really like all of those suggestions. Thanks @Asartea, you have a good eye for this.