Closed KevinMulhern closed 3 months ago
Steps for QA: Review app url: https://odin-review-app-pr-4592.herokuapp.com/admin_v2
Haven't had time to review everything yet, but preliminary notes:
I've fixed the issue with the avatar updating - that was due to morphing đ
But I'm not seeing any freezing. Would you mind tailing your dev logs tail -f log/development.log
and posting anything that comes after the patch request the next time it freezes for you please? Anything below the line which includes this:Started PATCH "/admin_v2/profile"
But I'm not seeing any freezing. Would you mind tailing your dev logs tail -f log/development.log and posting anything that comes after the patch request the next time it freezes for you please? Anything below the line which includes this:Started PATCH "/admin_v2/profile"
Am unable to repro now: going to blame this on just something being weird with my local environment unless proven otherwise
Nice! thanks @Asartea. It's very possible the fix for the avatar sorted out freezing too. Turbo morphing changes the behaviour of page visits/ form submissions
QA:
Updating name and email:
Updating password:
With non matching new passwords: (although could we change the feedback message to something a bit more descriptive? Maybe 'Password and Password confirmation must be the same)
With wrong current password (same feedback as previous: maybe 'Incorrect password')
Works on team page:
Nit: on smaller window sizes the gap between the two containers becomes a bit too small: can we enforce a slightly wider min gap?
â Can successfully sign in with new email + password â Can no longer sign in with old email + password âšī¸ Have reset the password + email back on review app
Really like all of those suggestions. Thanks @Asartea, you have a good eye for this.
Because:
This commit: