Closed KevinMulhern closed 3 weeks ago
Is there a better icon we can use for the "Deactivate" option? needs to be from Heroicons to keep our icons consistent
Note: This can only be tested locally, we can't send emails on review apps.
Steps for QA
As the deactivated admin...
@KevinMulhern could you please post what the admin v2 url should look like so I know what to append to the deployment? I have to dig it up from an old PR and I'm here not often enough to remember.
I tried \admin
, \adminv2
, and \v2
.
@zachmmeyer admin_v2/
Thought: should we add links to admin and admin v2 to the sidebar when in a development environment?
@Asartea Thank you! That definitely seems to be it. I don't think it's entirely necessary to add it in to the code or anything, it just should be part of the AC for testing purposes. That way anyone can come in and test it.
@KevinMulhern I'm getting a 500 when inviting a new team member.
I haven't tried anything weird with the input strings yet.
~~As for the icon, of which I can't see yet, I think the user-minus
icon would be appropriate.
Not sure what's being used currently.~~
I should have looked at the source files.
Are you running this locally or on the review app? If its the review app this is probably because it doesn't have an email provider, so trying to send an email causes the server to freak out.
I'm using the deployment link from GitHub.
Hey @zachmmeyer, sorry, I'll make sure to include the path in all the PR's that come after.
The 500 is likely coming from the invitation email that needs to be sent. We don't have emails set up on review apps currently, this one needs to be tested locally I'm afraid.
@KevinMulhern I'm going to give running this locally a shot (been a real long time) but I won't be upset if someone else reviews this before I do.
No worries Zach, thanks anyway!
Note: I already got this notice when I refreshed: not sure if this was intentional, but seems fine to me
Because:
This commit: