Closed KevinMulhern closed 2 weeks ago
Steps for QA:
/sidekiq/cron
/admin_v2
and log in with admin@odin.com, password123QA:
Log in as a learner - kevin@odin.com, password ✅
Visit foundations and complete 5 lessons
Wait 5 minutes for our reports refresh job to run - you can check the status by visiting this path: /sidekiq/cron ✅
Visit /admin_v2 and log in with admin@odin.com, password123 ✅
Visit "Analytics -> All lesson completions" from the sidebar ✅
The lesson completions graph should have 5 as the the value for today
Switch to month view, the graph should have 5 as the value for this month
Nit: If possible the y-axis of the chart should be constrained to integers only: It makes no sense to measure a .1 lesson completion Nit: It might be nice to seed some values for the graph if possible, because right now I can only test on a single datapoint (today), and would have to wait until tomorrow to test a second one
:bug: Bug: Manually messing with the date selector seems to do weird things to the Day/Month switches.
I manually set the range from July 9 to July 9, and clicking the month button got me this view
It seems that if the date range doesn't include at least one first of the month the month view just breaks
I then manually set the range to July 2 - 9, and clicked the day button, which produced this:
While technically correct, now the first value on the x-axis is July 9, whereas the first value in my selection is July 2
Thanks for the feedback @Asartea ⭐
If possible the y-axis of the chart should be constrained to integers only: It makes no sense to measure a .1 lesson completion
Done ✅
It seems that if the date range doesn't include at least one first of the month the month view just breaks
Thanks for pointing this out, I think I initially overcooked how we were handling months in favour of performance. I found a better, simpler way of handling months that should fix this and make it much more flexible ✅
While technically correct, now the first value on the x-axis is July 9, whereas the first value in my selection is July 2
I see what you mean with this. The x-axis labels come from the available dataset rather than the date selection. I think it's more of a available data problem than a bug. In production it won't be an issue, we'll always have lesson completions everyday in the available date range. I'm willing to let this one slide.
Because:
This commit:
https://github.com/TheOdinProject/theodinproject/assets/7963776/caad6b73-f00a-4dfe-a49f-65f32b05044f