TheOdinProject / theodinproject

Main Website for The Odin Project
http://www.theodinproject.com
MIT License
3.67k stars 2.07k forks source link

Project: SQL Zoo: No need for community solutions #4630

Closed dilpreetsinghaulakh closed 1 month ago

dilpreetsinghaulakh commented 1 month ago

Checks

Describe your suggestion

SQL Zoo is solved in the browser so there is no need for community solutions as there is no obvious way to share the solution.

Also, "feedback form for the SQL course" leads to (says) ruby on rails form even in NodeJS path.

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-databases-sql-zoo

(Optional) Discord Name

No response

(Optional) Additional Comments

Just small discrepancies!

wise-king-sullyman commented 1 month ago

Thanks for submitting this issue!

I fixed the google form issue since that requires admin access to our gforms.

For the SQL Zoo lesson submissions I believe that change requires an update in our site repo, specifically of the accepts_submissions key for the lesson in its fixture file, so I'm going to transfer this issue to that repo.

Are you still interested in making that change?

dilpreetsinghaulakh commented 1 month ago

I think it can actually stay as I have just seen a submission in which the submitter put the solutions for SQL Zoo in a repository. Although I still don't think it is the best implementation here.

MaoShizhong commented 1 month ago

I feel like user submissions isn't really that relevant here given the SQLZoo exercises are marked right or wrong when you do them. So I'm in favour of just removing the submissions component for that lesson.

Asartea commented 1 month ago

Agree with Mao that there is no real point to storing these, since there is already build in checking

MaoShizhong commented 1 month ago

@dilpreetsinghaulakh Are you still happy to be assigned to this issue and change the accepts_submissions value to false as per wise-king-sullyman's comment above?