Closed 01zulfi closed 1 year ago
I like this.
What do you think about also incorperating a part on protected routes? Could go well with writing custom hooks.
Protected routes slipped my mind. I'd be down for a section on them. I think protected routes would be a better fit for the React Router lesson in the new React Ecosystem section.
Unless I'm misreading the intent, when to use useEffect shouldn't be covered this late. That's something that should be covered whenever useEffect is first introduced, preferably before the section on class components since the connection between useEffect and lifecycle methods could be good for users to learn. I'm not sure if we need an entire lesson on a deep dive into effects, but it might depend what would actually be included.
Otherwise for the "More Hooks And Writing Custom Hooks" lesson, we should be sure to not re-write documentation (not just explain what the hook does, but be sure we can provide content beyond what just reading the documentation can provide), and to not provide content for the sake of it (I don't think we need to cover every hook, just ones users may be able to make use out of in the project the user does next).
Unless I'm misreading the intent, when to use useEffect shouldn't be covered this late. That's something that should be covered whenever useEffect is first introduced, preferably before the section on class components since the connection between useEffect and lifecycle methods could be good for users to learn. I'm not sure if we need an entire lesson on a deep dive into effects, but it might depend what would actually be included.
Agreed. useEffect (and all the information surrounding it) should be covered in the States And Effects section. I'll hold off on a deep dive lesson.
Otherwise for the "More Hooks And Writing Custom Hooks" lesson, we should be sure to not re-write documentation (not just explain what the hook does, but be sure we can provide content beyond what just reading the documentation can provide), and to not provide content for the sake of it (I don't think we need to cover every hook, just ones users may be able to make use out of in the project the user does next).
Somewhat agreed. I think there's value in covering refs and memoization even if user doesn't find a use case in their projects, but "writing custom hooks" could be removed entirely. Custom hooks will eventually be covered:
More React Concepts
Section Summary
Section Lessons